fix(ObjectStorePreviewStorage): Close count stream wrapper - #63849
Conversation
|
/backport to stable35 |
|
/backport to stable34 |
|
/backport to stable33 |
|
Production data point in favour of backporting this to stable34. We hit this on 34.0.2 with OpenStack Swift as primary storage. The impact is bigger than log noise, because the preview is never recorded in
For comparison the files path gets this right — $this->objectStore->writeObject($urn, $countStream, ...);
if (is_resource($countStream)) {
fclose($countStream);
}
$stat['size'] = $totalWritten;Carrying this patch locally meanwhile; it applies cleanly to 34.0.2. Happy to test a stable34 backport. |
So that the size is finalized Signed-off-by: Carl Schwan <carl@carlschwan.eu>
3577473 to
f25935b
Compare
Summary
So that the size is finalized
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)